Categories: MySQLDevelopment | Contributing

Code Review Process


[edit] Introduction to the MySQL Code Review Process

Regardless of whether it is a community-contributed patch or a commit of code done by a MySQL developer, there is a standardized process by which code is reviewed and checked before being pushed into one of the team or main code trees.

Code is checked in to the developer's local repository (via the bk citool command) along with a description of the changeset and any corresponding bug or WorkLog entry for which the patch addresses. This check in triggers an email to the maintainers of the code tree under which the code has been checked in. The code writer is then responsible for getting at least two developers to review the code before it is approved and then pushed into the team tree. We'll cover what happens after the push to a team tree in a bit. Let's take a look at the review criteria that MySQL code reviewers use when evaluating code.

[edit] Review Criteria

prepare the-query-which-contains-the-guist-of-the-patch;
do some unrelated query just to mangle THD a bit;
execute;
execute; # 2nd time sometimes gives funny things - I know it well
void myfunction()
{
  char buffer[1024*1024];
...
}

Retrieved from "http://forge.mysql.com/wiki/Code_Review_Process"

This page has been accessed 2,736 times. This page was last modified 10:17, 18 June 2007.

Find

Browse
MySQLForge
Main Page
Current events
Recent changes
Random page
Help
Edit
Edit this page
Editing help
This page
Discuss this page
Post a comment
Printable version
Context
Page history
What links here
Related changes
My pages
Special pages
New pages
File list
Statistics
Bug reports
More...